-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make tickers module keep token exponents too #78
Conversation
@hallazzang can you rebase this please? 🙏 |
bd18713
to
69cc147
Compare
f0d97cd
to
c871758
Compare
Done! |
68ce1cc
to
811b64a
Compare
@hallazzang Can you please resolve the conflicts, and remove all the changes related to the |
But these changes to the rewards module have been made because of the changes in this PR. Without updating the rewards module accordingly, build will fail. |
Got it, thanks. Will mark this module as ready to be merged once the rewards module is merged then (will add the dependency into the description). |
@hallazzang Could you please rebase/merge |
|
33c6722
to
1b3a738
Compare
1b3a738
to
a5f520e
Compare
Description
Instead of simply keeping denom-ticker mappings, this PR introduces new
Asset
type which holds the exponent as well. With this change it's possible to calculate dollar values of an asset correctly with assets with different exponents.Closes: MILK-66
Depends-On: #63
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change