Optimize implementation to try to eliminate warnings about blocking #2

mill1000 · 2023-11-07T21:45:10Z

Parse single sentences at a time
Publish states separately from sentence reception
Only publish changed states
Use enums for keys to reduce the number of string comparisons
Remove zero-initialization of buffers
Tokenize the sentence in place
Reduce buffer sizes
Preallocate strings when possible and perform in-place edits

Current warnings are

[21:42:22][W][component:214]: Component winix_c545 took a long time for an operation (0.15 s).
[21:42:22][W][component:215]: Components should block for at most 20-30ms.

with these changes it's reduced by about half

[22:03:05][W][component:214]: Component winix_c545 took a long time for an operation (0.08 s).
[22:03:05][W][component:215]: Components should block for at most 20-30ms.

Close #1

AT*ICT*AWS_SEND=A210 {"A02":"0","A03":"01","A04":"00","A05":"01","A07":"0","A21":"XXXXX","S07":"01","S08":"100","S14":"100"}

…which was zero-padding the remainder of the destination buffer

…mands.

…unnecessary std::string construction

… line as been read

…locking time

…ngs as necessary. This converts a number of string comparison to integer comparisons which should be faster

mill1000 added the enhancement New feature or request label Nov 7, 2023

mill1000 self-assigned this Nov 7, 2023

mill1000 added 16 commits November 7, 2023 14:45

Reduce maximum line length based on the following theoretical sentence

862f2cc

AT*ICT*AWS_SEND=A210 {"A02":"0","A03":"01","A04":"00","A05":"01","A07":"0","A21":"XXXXX","S07":"01","S08":"100","S14":"100"}

Don't zero-init the payload buffer and switch to strcpy over strncpy …

8ee61a8

…which was zero-padding the remainder of the destination buffer

Reduce the size and skip zero-init the buffer when building state com…

23ada42

…mands.

Appending the buffer to the command sentence in hopes of avoiding an …

7c3042b

…unnecessary std::string construction

Pre-allocate the TX sentence in hopes of avoiding any reallocation

a006495

Replace the trailing comma in place instead of popping and appending.

1de4775

Write the TX sentence in parts instead of building a new string

8975ed7

Update readline_ to only insert the null-terminator when the complete…

2272590

… line as been read

Tokenize sentence in place for better performance

cee4318

Only process a single sentence at a time

ed91307

Publish states independently of sentence RX in an attempt to reduce b…

a9948c1

…locking time

Only publish states when they've changed

eb8e833

Use enumerated values for the various state keys and map to/from stri…

9340ea3

…ngs as necessary. This converts a number of string comparison to integer comparisons which should be faster

Use switch-case for new enum keys

e775262

Only send AQI indicator updates when the raw value changes

b175ef7

Remove logging of status sentence

7b02941

mill1000 force-pushed the issue/optimizations branch from d19ce9f to 7b02941 Compare November 7, 2023 21:45

Tweak RX loop. Remove min size check and some locals

3e51bd1

mill1000 merged commit b7a9c29 into main Nov 7, 2023
2 checks passed

mill1000 deleted the issue/optimizations branch November 7, 2023 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize implementation to try to eliminate warnings about blocking #2

Optimize implementation to try to eliminate warnings about blocking #2

mill1000 commented Nov 7, 2023 •

edited

Loading

Optimize implementation to try to eliminate warnings about blocking #2

Optimize implementation to try to eliminate warnings about blocking #2

Conversation

mill1000 commented Nov 7, 2023 • edited Loading

mill1000 commented Nov 7, 2023 •

edited

Loading