enhance: Update protobuf-go to protobuf-go v2 (#294) (#312)

* enhance: Update protobuf-go to protobuf-go v2 (#294) Signed-off-by: Wei Liu <[email protected]> * enhance: make sure protoc-gen-go v2 will be used to generate pb msg (#298) Signed-off-by: Wei Liu <[email protected]> --------- Signed-off-by: Wei Liu <[email protected]>
milvus-io · Aug 21, 2024 · 950375c · 950375c
1 parent 512e3b9
commit 950375c
Show file tree

Hide file tree

Showing 11 changed files with 22,371 additions and 13,692 deletions.
diff --git a/Makefile b/Makefile
@@ -3,6 +3,7 @@ PWD 	:= $(shell pwd)
 GOPATH 	:= $(shell $(GO) env GOPATH)
 PROTOC	:= $(shell which protoc)
 PROTOC_VER := $(shell protoc --version)
+INSTALL_PATH := $(PWD)/bin
 
 all: generate-proto
 
@@ -11,8 +12,10 @@ build:
 
 generate-proto: export protoc:=${PWD}/cmake-build/protobuf/protobuf-build/protoc
 generate-proto: build
-	@which protoc-gen-go 1>/dev/null || (echo "Installing protoc-gen-go" && go install github.com/golang/protobuf/[email protected])
-	@(env bash $(PWD)/scripts/proto_gen_go.sh)
+	@echo "Generate proto files"
+	@echo "Installing protoc-gen-go to ./bin" && GOBIN=$(INSTALL_PATH) go install google.golang.org/protobuf/cmd/[email protected]
+	@echo "Installing protoc-gen-go-grpc to ./bin" && GOBIN=$(INSTALL_PATH)  go install google.golang.org/grpc/cmd/[email protected]
+	@(env bash $(PWD)/scripts/proto_gen_go.sh $(INSTALL_PATH))
 
 clean:
 	@echo "Cleaning up all the generated files"