Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change C# namespace to Milvus.Client #183

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Change C# namespace to Milvus.Client #183

merged 1 commit into from
Jul 24, 2023

Conversation

roji
Copy link
Contributor

@roji roji commented Jul 23, 2023 •
edited
Loading

As per offline discussions, the Milvus .NET SDK will have the nuget name and namespace Milvus.Client, which is the idiomatic .NET naming (rather than IO.Milvus).

/cc @weianweigan @stephentoub @tawalke

issue: #184

@sre-ci-robot
Copy link

@roji: GitHub didn't allow me to request PR reviews from the following users: weianweigan, stephentoub, tawalke.

Note that only milvus-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

As per offline discussions, the Milvus .NET SDK will have the nuget name and namespace Milvus.Client, which is the idiomatic .NET naming (rather than IO.Milvus).

/cc @weianweigan @stephentoub @tawalke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link

Welcome @roji! It looks like this is your first PR to milvus-io/milvus-proto 🎉

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jul 23, 2023
@mergify
Copy link

mergify bot commented Jul 23, 2023

@roji Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

@roji roji force-pushed the CSharpNamespace branch from 35b784c to d1ef9b4 Compare July 23, 2023 20:02
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. do-not-merge/missing-related-issue labels Jul 23, 2023
@weianweigan
Copy link

/assign @yhmo

@weianweigan
Copy link

@roji common.proto and schema.proto also have a C# namespace. Maybe we should change them together ?
It seems that the active branch for milvus-proto is in version 2.2. Perhaps the target branch should be set to branch 2.2 ?

@mergify mergify bot added the ci-passed label Jul 24, 2023
@roji roji force-pushed the CSharpNamespace branch from d1ef9b4 to 17ca43d Compare July 24, 2023 08:55
@mergify mergify bot added ci-passed and removed ci-passed labels Jul 24, 2023
@yhmo
Copy link
Collaborator

yhmo commented Jul 24, 2023

Hi, @roji
Could you cherry-pick this pr to the 2.2 branch?: https://github.com/milvus-io/milvus-proto/tree/2.2

@roji roji changed the base branch from master to 2.2 July 24, 2023 09:01
@roji roji force-pushed the CSharpNamespace branch from 17ca43d to 7dd6a04 Compare July 24, 2023 09:01
@mergify mergify bot removed the ci-passed label Jul 24, 2023
@roji
Copy link
Contributor Author

roji commented Jul 24, 2023

Thanks @weianweigan! I changed the C# namespace in the other proto files as well and rebased the PR against the 2.2 branch. I can also see commits in master, so it's a bit confusing - let me know if all is good.

@mergify mergify bot added the ci-passed label Jul 24, 2023
@yhmo
Copy link
Collaborator

yhmo commented Jul 24, 2023

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roji, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ea9f142 into milvus-io:2.2 Jul 24, 2023
@weianweigan
Copy link

Thanks @roji! It's all good. The updates on the master branch are prepared for versions 2.3 and 2.4.

@roji roji deleted the CSharpNamespace branch July 24, 2023 09:16
yhmo pushed a commit to yhmo/milvus-proto that referenced this pull request Jul 24, 2023
@roji @yhmo
Change C# namespace to Milvus.Client (milvus-io#183)
3173042 
Signed-off-by: Shay Rojansky <[email protected]>
yhmo added a commit that referenced this pull request Jul 24, 2023
@yhmo @roji
Change C# namespace to Milvus.Client (#183) (#185)
fff4068 
Signed-off-by: Shay Rojansky <[email protected]>
Co-authored-by: Shay Rojansky <[email protected]>
Writer-X pushed a commit to Writer-X/milvus-proto that referenced this pull request Aug 14, 2023
@yhmo @roji @Writer-X
Change C# namespace to Milvus.Client (milvus-io#183) (milvus-io#185)
10dd299 
Signed-off-by: Shay Rojansky <[email protected]>
Co-authored-by: Shay Rojansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yhmo yhmo

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roji @sre-ci-robot @weianweigan @yhmo