Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VerifyAPIKey method for the hook interface #204

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Oct 17, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 17, 2023
@mergify mergify bot added dco-passed DCO check passed. ci-passed labels Oct 17, 2023
@yhmo
Copy link
Collaborator

yhmo commented Oct 17, 2023

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5e5a27f into milvus-io:master Oct 17, 2023
3 checks passed
SimFG added a commit to SimFG/milvus-proto that referenced this pull request Oct 18, 2023
SimFG added a commit that referenced this pull request Oct 18, 2023
* Add properties (#198)

Signed-off-by: xiaofan-luan <[email protected]>

* Add VerifyAPIKey method for the hook interface (#204)

Signed-off-by: SimFG <[email protected]>

---------

Signed-off-by: xiaofan-luan <[email protected]>
Signed-off-by: SimFG <[email protected]>
Co-authored-by: Xiaofan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants