Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GetLoadStateRequest/GetLoadingProgressRequest use wrong privilege #307

Closed
wants to merge 1 commit into from

Conversation

weiliu1031
Copy link
Contributor

cause GetLoadStateRequest/GetLoadingProgressRequest use the wrong privilege PrivilegeLoad, so if we want grant a role the privilege to execute GetLoadState and GetLoadingProgress, we must grant PrivilegeLoad to the role.

This PR correct the privilege for GetLoadStateRequest/GetLoadingProgressRequest

cause GetLoadStateRequest/GetLoadingProgressRequest use the wrong
privilege `PrivilegeLoad`, so if we want grant a role the privilege to
execute GetLoadState and GetLoadingProgress, we must grant
`PrivilegeLoad` to the role.

This PR correct the privilege for GetLoadStateRequest/GetLoadingProgressRequest

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Aug 14, 2024
Copy link

mergify bot commented Aug 14, 2024

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

@xiaofan-luan
Copy link
Collaborator

cause GetLoadStateRequest/GetLoadingProgressRequest use the wrong privilege PrivilegeLoad, so if we want grant a role the privilege to execute GetLoadState and GetLoadingProgress, we must grant PrivilegeLoad to the role.

This PR correct the privilege for GetLoadStateRequest/GetLoadingProgressRequest

I think that is the expected behaviour? Who ever do load must have getLoadState privilege. And it's same that if you do getLoadState usually the load is triggered by you

@weiliu1031 weiliu1031 closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants