Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support credentials. #202

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Conversation

matrixji
Copy link
Collaborator

Fixes: #183

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #202 (d71c2d5) into master (0636640) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   99.41%   99.42%   +0.01%     
==========================================
  Files          47       47              
  Lines        2374     2444      +70     
==========================================
+ Hits         2360     2430      +70     
  Misses         14       14              
Impacted Files Coverage Δ
src/impl/MilvusClientImpl.h 100.00% <ø> (ø)
src/impl/MilvusConnection.h 93.75% <ø> (ø)
src/impl/TypeUtils.h 100.00% <ø> (ø)
src/impl/MilvusClientImpl.cpp 99.35% <100.00%> (+0.03%) ⬆️
src/impl/MilvusConnection.cpp 100.00% <100.00%> (ø)
src/impl/TypeUtils.cpp 98.71% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot added the ci-passed label Sep 17, 2022
@ArkaprabhaChakraborty
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit a4fb293 into milvus-io:master Sep 18, 2022
@matrixji matrixji deleted the support-credentials branch December 22, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement credential interfaces
3 participants