fix: unittest

Signed-off-by: chyezh <[email protected]>
milvus-io · Jan 22, 2025 · cd1b827 · cd1b827
1 parent eb4d9e3
commit cd1b827
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/internal/streamingcoord/client/broadcast/watcher_resuming.go b/internal/streamingcoord/client/broadcast/watcher_resuming.go
@@ -4,7 +4,7 @@ import (
 	"context"
 	"time"
 
-	"github.com/pkg/errors"
+	"github.com/cockroachdb/errors"
 	"go.uber.org/zap"
 
 	"github.com/milvus-io/milvus/pkg/log"
@@ -141,10 +141,9 @@ func (evs *pendingEvents) AddPendingEvent(ev *pendingEvent) bool {
 	if existEv, ok := evs.evs[id]; ok {
 		existEv.notifier = append(existEv.notifier, ev.notifier...)
 		return true
-	} else {
-		evs.evs[id] = ev
-		return false
 	}
+	evs.evs[id] = ev
+	return false
 }
 
 func (evs *pendingEvents) Notify(ev *message.BroadcastEvent) {

diff --git a/internal/streamingcoord/server/broadcaster/broadcast_task.go b/internal/streamingcoord/server/broadcaster/broadcast_task.go
@@ -4,7 +4,7 @@ import (
 	"context"
 	"sync"
 
-	"github.com/pkg/errors"
+	"github.com/cockroachdb/errors"
 	"go.uber.org/zap"
 
 	"github.com/milvus-io/milvus/internal/streamingcoord/server/resource"

diff --git a/internal/streamingcoord/server/broadcaster/broadcaster_test.go b/internal/streamingcoord/server/broadcaster/broadcaster_test.go
@@ -118,7 +118,7 @@ func TestBroadcaster(t *testing.T) {
 	// Test broadcast with a already exist resource key.
 	for {
 		var err error
-		result, err = bc.Broadcast(context.Background(), createNewBroadcastMsg([]string{"v1", "v2", "v3"}, message.NewCollectionNameResourceKey("c7")))
+		_, err = bc.Broadcast(context.Background(), createNewBroadcastMsg([]string{"v1", "v2", "v3"}, message.NewCollectionNameResourceKey("c7")))
 		if errors.Is(err, errResourceKeyHeld) {
 			break
 		}

diff --git a/internal/streamingcoord/server/service/broadcast/broadcast_watch_server.go b/internal/streamingcoord/server/service/broadcast/broadcast_watch_server.go
@@ -2,9 +2,9 @@ package broadcast
 
 import (
 	"context"
-	"errors"
 	"io"
 
+	"github.com/cockroachdb/errors"
 	"go.uber.org/zap"
 
 	"github.com/milvus-io/milvus/internal/streamingcoord/server/broadcaster"