Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support Growing Search With Querynode Delegator And Streaming Service #38399

Open
10 tasks done
chyezh opened this issue Dec 12, 2024 · 0 comments
Open
10 tasks done
Assignees
Labels
feature/streaming node streaming node feature kind/enhancement Issues or changes related to enhancement
Milestone

Comments

@chyezh
Copy link
Contributor

chyezh commented Dec 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Also see the parent issue #33285.
Detail coming soon.

Why is this needed?

In order to quickly access growing query at streaming architecture in 2.6.
We are now implementing an intermediate version of StreamingService by the current delegator implemetation.
Since 2.6:

  • Every Streaming Node will embed a Query Node in it directly (Standalone mode will also embed an extra querynode in it).
  • The new query node embedded in streaming node will be different with legacy querynode at coord view by assign a special server label QUERYNODE_STREAMING-EMBEDED, named streaming query node, aka. sqn.
  • QueryCoord will assign the delegator(channel) only on the sqn, and assign the sealed segment only on legacy querynode.
  • The querycoord will assign the channel on the sqn which the vchannel related wal located as much as possible.
  • The replica manager will see the sqn, but the resource group manager will not. To avoid break the resource group api.

Here's the TODO list, part of them is extra enhancement for 2.6:

Anything else?

No response

@chyezh chyezh added kind/enhancement Issues or changes related to enhancement feature/streaming node streaming node feature labels Dec 12, 2024
@chyezh chyezh self-assigned this Dec 12, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 17, 2024
#38442)

issue: #38399

- move the lifetime implementation of common code out of the server
level lifetime implementation

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh added this to the 2.6.0 milestone Dec 17, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 17, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 23, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 24, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 24, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 25, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 25, 2024
issue: #38399

---------

Signed-off-by: chyezh <[email protected]>
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this issue Dec 26, 2024
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this issue Dec 26, 2024
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this issue Dec 26, 2024
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this issue Dec 26, 2024
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this issue Dec 26, 2024
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this issue Dec 26, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 27, 2024
issue: #38399

- use last allocate but not last confirmed id to make barrier. 
- move the barrier logic into the timetick allocator.
- try to sync up local allocator and remote allocator when first barrier
check not pass to speed up.

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Dec 30, 2024
sunby pushed a commit to sunby/milvus that referenced this issue Jan 6, 2025
sre-ci-robot pushed a commit that referenced this issue Jan 7, 2025
issue: #38399

We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier
implementation.

---------

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Jan 7, 2025
issue: #38399
pr: #39007

We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier
implementation.

---------

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Jan 8, 2025
sre-ci-robot pushed a commit that referenced this issue Jan 9, 2025
issue: #38399 

- Add new rpc for transfer broadcast to streaming coord
- Add broadcast service at streaming coord to make broadcast message
sent automicly

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Jan 9, 2025
issue: #38399
pr: #39020

- Add new rpc for transfer broadcast to streaming coord
- Add broadcast service at streaming coord to make broadcast message
sent automicly

also cherry pick the pr #38400

---------

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Jan 14, 2025
issue: #38399
pr: #39040

- make broadcast service available for msgstream by reusing the
architecture streaming service

---------

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Jan 14, 2025
issue: #38399

- make broadcast service available for msgstream by reusing the
architecture streaming service

---------

Signed-off-by: chyezh <[email protected]>
gifi-siby pushed a commit to gifi-siby/milvus that referenced this issue Jan 16, 2025
issue: milvus-io#38399

- make broadcast service available for msgstream by reusing the
architecture streaming service

---------

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Jan 24, 2025
issue: #38399

- Embed the query node into streaming node to make delegator available
at streaming node.
- The embedded query node has a special server label
`QUERYNODE_STREAMING-EMBEDDED`.
- Change the balance strategy to make the channel assigned to streaming
node as much as possible.

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Feb 5, 2025
issue: #38399

- The stats may be kept after wal closing if the growing segment is not
dirty.
- Change the error handling of wal open to avoid redundant manager api
call.

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Feb 5, 2025
issue: #38399

- Make the wal scanner interface same with streaming scanner.
- Use wal if the wal is located at current node.
- Otherwise fallback the old logic.

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/streaming node streaming node feature kind/enhancement Issues or changes related to enhancement
Projects
None yet
Development

No branches or pull requests

1 participant