Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: move streaming coord from datacoord to rootcoord #39007

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 6, 2025

issue: #38399

We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier implementation.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 6, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 6, 2025
@chyezh chyezh force-pushed the enhance_move_streaming_coord_to_rc branch from 4c8b4fe to 06f9c9f Compare January 6, 2025 06:47
Copy link
Contributor

mergify bot commented Jan 6, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 87.60331% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (ee9a279) to head (d7e6f98).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/distributed/rootcoord/service.go 50.00% 4 Missing and 2 partials ⚠️
internal/streamingcoord/server/server.go 83.33% 4 Missing and 1 partial ⚠️
internal/rootcoord/root_coord.go 84.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39007       +/-   ##
===========================================
+ Coverage   69.52%   81.14%   +11.62%     
===========================================
  Files         296     1389     +1093     
  Lines       26553   196503   +169950     
===========================================
+ Hits        18462   159461   +140999     
- Misses       8091    31451    +23360     
- Partials        0     5591     +5591     
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.54% <ø> (+0.01%) ⬆️
Go 83.10% <87.60%> (∅)
Files with missing lines Coverage Δ
internal/coordinator/coordclient/registry.go 92.20% <100.00%> (ø)
internal/datacoord/server.go 73.20% <ø> (ø)
internal/distributed/datacoord/service.go 88.51% <ø> (ø)
internal/streamingcoord/client/client.go 96.72% <100.00%> (ø)
...al/streamingcoord/server/balancer/balancer_impl.go 77.22% <100.00%> (ø)
internal/streamingcoord/server/builder.go 100.00% <100.00%> (ø)
...nternal/streamingcoord/server/resource/resource.go 95.55% <100.00%> (ø)
...nal/streamingcoord/server/resource/test_utility.go 100.00% <100.00%> (ø)
...ngcoord/server/service/discover/discover_server.go 96.07% <100.00%> (ø)
...amingutil/service/discoverer/session_discoverer.go 88.37% <100.00%> (ø)
... and 6 more

... and 1078 files with indirect coverage changes

@chyezh chyezh force-pushed the enhance_move_streaming_coord_to_rc branch from 06f9c9f to a63f8a7 Compare January 6, 2025 09:02
Copy link
Contributor

mergify bot commented Jan 6, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_move_streaming_coord_to_rc branch from 410ccce to bc5f16a Compare January 6, 2025 14:21
Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_move_streaming_coord_to_rc branch from bc5f16a to d7e6f98 Compare January 7, 2025 01:21
Copy link
Contributor

mergify bot commented Jan 7, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 7, 2025

rerun go-sdk

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c5a7000 into milvus-io:master Jan 7, 2025
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jan 7, 2025
issue: #38399
pr: #39007

We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier
implementation.

---------

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants