Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refine misleading param name for bloom filter parallel factor #34334

Merged
merged 1 commit into from
Jul 4, 2024
Merged

enhance: refine misleading param name for bloom filter parallel factor #34334

merged 1 commit into from
Jul 4, 2024

Conversation

weiliu1031
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 2, 2024
@weiliu1031 weiliu1031 mentioned this pull request Jul 2, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

sre-ci-robot pushed a commit that referenced this pull request Jul 2, 2024
@weiliu1031
enhance: refine misleading param name for bloom filter parallel factor (
ad545b6 
#34335)

pr: #34334

Signed-off-by: Wei Liu <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (feb13cd) to head (7440801).
Report is 8 commits behind head on master.

❗ Current head 7440801 differs from pull request most recent head 63ff3c3

Please upload reports for the commit 63ff3c3 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34334      +/-   ##
==========================================
+ Coverage   80.58%   83.82%   +3.24%     
==========================================
  Files        1095      826     -269     
  Lines      137929   113662   -24267     
==========================================
- Hits       111145    95276   -15869     
+ Misses      22573    14235    -8338     
+ Partials     4211     4151      -60
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.48% <100.00%> (+<0.01%) ⬆️

... and 321 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 3, 2024
congqixia
congqixia approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9db8979 into milvus-io:master Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weiliu1031 @sre-ci-robot @congqixia