Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove isFull check in compaction.enqueue #34338

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: remove isFull check in compaction.enqueue #34338

merged 1 commit into from
Jul 3, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Jul 2, 2024 •
edited
Loading

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug do-not-merge/missing-related-issue labels Jul 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink wayblink force-pushed the fix-pk-major branch 2 times, most recently from 8f71852 to 169cc82 Compare July 3, 2024 06:43
@czs007
Copy link
Contributor

czs007 commented Jul 3, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jul 3, 2024
@sre-ci-robot sre-ci-robot merged commit a501fa1 into milvus-io:master Jul 3, 2024
10 checks passed
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 3, 2024
@wayblink
fix: remove isFull check in compaction.enqueue (milvus-io#34338)
2ff7b18 
milvus-io#30633

Signed-off-by: wayblink <[email protected]>
@wayblink wayblink mentioned this pull request Jul 3, 2024
Merged
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 4, 2024
@wayblink
fix: remove isFull check in compaction.enqueue (milvus-io#34338)
de172e6 
milvus-io#30633

Signed-off-by: wayblink <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Jul 4, 2024
@wayblink
fix:[cherry-pick] minor fixs for major compaction (#34402)
b3aec4c 
This PR cherry-picks the following commits:

- fix: Avoid datarace in clustering compaction #34288
- fix: remove isFull check in compaction.enqueue #34338

issue: #30633 
pr: #34288 #34338

---------

Signed-off-by: wayblink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wayblink @czs007 @sre-ci-robot