Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct the update logic of timerecorder #34339

Merged
merged 8 commits into from
Jul 4, 2024
Merged

fix: Correct the update logic of timerecorder #34339

merged 8 commits into from
Jul 4, 2024

Conversation

bigsheeper
Copy link
Contributor

Correct the update logic of timerecorder in the flowgraph to avoid false failure: "some node(s) haven't received input".

issue: #34337

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 2, 2024
@bigsheeper bigsheeper added the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.4.6 milestone Jul 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun ut

@bigsheeper bigsheeper removed the PR | need cherry-pick need cherry pick to other branches label Jul 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added the PR | need cherry-pick need cherry pick to other branches label Jul 3, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.6, 2.5.0 Jul 3, 2024
@bigsheeper bigsheeper mentioned this pull request Jul 3, 2024
Merged
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jul 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (23e2a0e) to head (6bf37d5).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34339      +/-   ##
==========================================
- Coverage   84.31%   80.86%   -3.45%     
==========================================
  Files         825     1094     +269     
  Lines      113633   137794   +24161     
==========================================
+ Hits        95809   111429   +15620     
- Misses      13601    22134    +8533     
- Partials     4223     4231       +8
Files Coverage Δ
internal/datanode/pipeline/flow_graph_dd_node.go 92.54% <100.00%> (ø)
...atanode/pipeline/flow_graph_dmstream_input_node.go 93.54% <100.00%> (ø)
...nternal/datanode/pipeline/flow_graph_write_node.go 85.07% <100.00%> (+0.45%) ⬆️
internal/util/flowgraph/node.go 84.15% <100.00%> (-2.98%) ⬇️

... and 296 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0b404bf into milvus-io:master Jul 4, 2024
12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 4, 2024
@bigsheeper @xiaofan-luan
enhance: [cherry-pick] optimize datanode cpu usage and correct the up…
a57c9e6 
…date logic of ttchecker (#34383)

This PR cherry-picks the following commits:
- Try to improve cpu usage by refactoring the ttchecker logic and
caching string. #33267
- Correct the update logic of timerecorder in the flowgraph to avoid
false failure: "some node(s) haven't received input".
#34339

issue: #33266,
#34337

pr: #33267,
#34339

---------

Signed-off-by: bigsheeper <[email protected]>
Co-authored-by: Xiaofan <[email protected]>
@bigsheeper bigsheeper mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby Awaiting requested review from sunby

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm PR | need cherry-pick need cherry pick to other branches size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bigsheeper @czs007 @sre-ci-robot @yanliang567