Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: reconstruct scalar part's code for segment-pruner(#30376) #34365

Merged
merged 1 commit into from
Jul 4, 2024
Merged

enhance: reconstruct scalar part's code for segment-pruner(#30376) #34365

merged 1 commit into from
Jul 4, 2024
+557 −13

Conversation

MrPresent-Han
Copy link
Contributor

related: #30376
pr: #34346

  1. support more complex expr
  2. add more ut test for unrelated fields

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jul 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.4.6 milestone Jul 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the reconstruc-segment-pruner-code-2.4 branch from afbbc2f to 6baf167 Compare July 3, 2024 02:50
@MrPresent-Han
Copy link
Contributor Author

rerun ut

@MrPresent-Han MrPresent-Han force-pushed the reconstruc-segment-pruner-code-2.4 branch 2 times, most recently from 307980a to 8a5de82 Compare July 3, 2024 07:53
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.85366% with 15 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (bc1746f) to head (ceb39e3).
Report is 9 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              2.4   #34365    +/-   ##
========================================
  Coverage   84.40%   84.40%            
========================================
  Files         776      777     +1     
  Lines      111811   112025   +214     
========================================
+ Hits        94370    94552   +182     
- Misses      13228    13278    +50     
+ Partials     4213     4195    -18
Files Coverage Δ
internal/querynodev2/delegator/segment_pruner.go 61.44% <100.00%> (-6.98%) ⬇️
internal/storage/field_value.go 61.31% <76.19%> (+1.63%) ⬆️
internal/querynodev2/delegator/ScalarPruner.go 92.24% <92.24%> (ø)

... and 36 files with indirect coverage changes

@MrPresent-Han MrPresent-Han force-pushed the reconstruc-segment-pruner-code-2.4 branch from 8a5de82 to 370fb94 Compare July 3, 2024 11:48
@mergify mergify bot added the ci-passed label Jul 3, 2024
@MrPresent-Han
enhance: reconstruct scalar part's code for segment-pruner(milvus-io#…
ceb39e3 
…30376)

1. support more complex expr
2. add more ut test for unrelated fields

Signed-off-by: MrPresent-Han <[email protected]>
@MrPresent-Han MrPresent-Han force-pushed the reconstruc-segment-pruner-code-2.4 branch from 370fb94 to ceb39e3 Compare July 4, 2024 02:34
@mergify mergify bot added ci-passed and removed ci-passed labels Jul 4, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5831908 into milvus-io:2.4 Jul 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
2.4.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrPresent-Han @czs007 @sre-ci-robot