Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: simplify compaction tasks to reduce their memory overhead #39121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Jan 9, 2025

See #39080

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby January 9, 2025 11:46
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Jan 9, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (4355b48) to head (fd38263).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39121   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         296      296           
  Lines       26633    26633           
=======================================
  Hits        18548    18548           
  Misses       8085     8085           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.64% <ø> (ø)
Go ∅ <ø> (∅)

@mergify mergify bot added the ci-passed label Jan 9, 2025
internal/datacoord/compaction.go Outdated Show resolved Hide resolved
internal/datacoord/compaction.go Outdated Show resolved Hide resolved
internal/datacoord/compaction_test.go Outdated Show resolved Hide resolved
internal/datacoord/compaction_test.go Outdated Show resolved Hide resolved
@mergify mergify bot removed the ci-passed label Jan 10, 2025
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 10, 2025
@tedxu tedxu force-pushed the enhance/simplify_compaction_tasks branch from 2855658 to fd38263 Compare January 10, 2025 06:05
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 10, 2025
@mergify mergify bot removed the ci-passed label Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants