Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: pass partition key scalar info if enable for vector mem index #39123

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

chasingegg
Copy link
Contributor

issue: #34332

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Jan 9, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 9, 2025
Copy link
Contributor

mergify bot commented Jan 9, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@chasingegg cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@chasingegg cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chasingegg cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jan 14, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 72 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (e501025) to head (105d8c9).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/MemFileManagerImpl.cpp 1.72% 57 Missing ⚠️
internal/core/src/index/VectorMemIndex.cpp 0.00% 9 Missing ⚠️
internal/core/src/storage/Util.h 40.00% 3 Missing ⚠️
internal/core/src/storage/Util.cpp 90.00% 2 Missing ⚠️
internal/core/src/query/PlanProto.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39123       +/-   ##
===========================================
+ Coverage   69.65%   81.03%   +11.37%     
===========================================
  Files         299     1406     +1107     
  Lines       26799   198358   +171559     
===========================================
+ Hits        18667   160731   +142064     
- Misses       8132    31969    +23837     
- Partials        0     5658     +5658     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.50% <27.27%> (-0.15%) ⬇️
Go 82.97% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/Types.h 30.24% <ø> (ø)
internal/core/src/storage/DiskFileManagerImpl.cpp 53.92% <100.00%> (-1.14%) ⬇️
internal/core/src/storage/MemFileManagerImpl.h 50.00% <ø> (ø)
internal/proxy/task.go 80.64% <100.00%> (ø)
internal/proxy/task_search.go 76.48% <100.00%> (ø)
internal/proxy/util.go 89.44% <100.00%> (ø)
internal/core/src/query/PlanProto.cpp 88.50% <75.00%> (-0.55%) ⬇️
internal/core/src/storage/Util.cpp 77.39% <90.00%> (+0.53%) ⬆️
internal/core/src/storage/Util.h 40.00% <40.00%> (ø)
internal/core/src/index/VectorMemIndex.cpp 62.70% <0.00%> (-1.76%) ⬇️
... and 1 more

... and 1104 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 14, 2025

@chasingegg cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PwzXxm
Copy link
Contributor

PwzXxm commented Jan 15, 2025

/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 15, 2025
@mergify mergify bot removed the ci-passed label Jan 15, 2025
Signed-off-by: chasingegg <[email protected]>
@PwzXxm
Copy link
Contributor

PwzXxm commented Jan 15, 2025

/lgtm

sre-ci-robot pushed a commit that referenced this pull request Jan 15, 2025
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 75d7978 into milvus-io:master Jan 16, 2025
18 of 20 checks passed
@chasingegg chasingegg deleted the support-mv branch January 16, 2025 06:46
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants