Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to replicate import msg #39171

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: support to replicate import msg #39171

wants to merge 6 commits into from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jan 11, 2025

No description provided.

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Jan 11, 2025
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file area/internal-api labels Jan 11, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 11, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 11, 2025

@SimFG Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@SimFG SimFG force-pushed the master branch 18 times, most recently from 6ed4694 to 9191fb5 Compare January 17, 2025 07:42
@SimFG SimFG force-pushed the master branch 2 times, most recently from 763820c to 96c9a5d Compare January 17, 2025 12:54
@SimFG SimFG force-pushed the master branch 2 times, most recently from ee8f782 to 735039f Compare January 17, 2025 14:28
@SimFG
Copy link
Contributor Author

SimFG commented Jan 17, 2025

rerun ut

@SimFG SimFG force-pushed the master branch 6 times, most recently from 6cd311e to dacf2c5 Compare January 23, 2025 04:03
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@SimFG Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Jan 23, 2025
chyezh and others added 5 commits January 23, 2025 16:44
@chyezh @SimFG
enhance: broadcast with event-based notification
b84b5a0 
- broadcast message can carry multi resource key now.
- implement event-based notification for broadcast messages
- broadcast message use broadcast id as a unique identifier in message
- broadcasted message on vchannels keep the broadcasted vchannel now.
- broadcasted message and broadcast message have a common broadcast
  header now.

Signed-off-by: chyezh <[email protected]>
@chyezh @SimFG
fix: unittest
afa2b7d 
Signed-off-by: chyezh <[email protected]>
@SimFG
support to replicate import msg
e0a7d5d 
Signed-off-by: SimFG <[email protected]>
@chyezh @SimFG
fix: make coordclient always available
2055226 
Signed-off-by: chyezh <[email protected]>
@chyezh @SimFG
fix: add resource key for import broadcast
d54abac 
Signed-off-by: chyezh <[email protected]>
@SimFG SimFG force-pushed the master branch 3 times, most recently from e0a3f8e to 37fcf81 Compare January 23, 2025 09:41
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@chyezh chyezh Awaiting requested review from chyezh

@congqixia congqixia Awaiting requested review from congqixia

Assignees
No one assigned
Labels
area/dependency Pull requests that update a dependency file area/internal-api area/test dco-passed DCO check passed. do-not-merge/missing-related-issue do-not-merge/work-in-progress Don't merge even CI passed. kind/feature Issues related to feature request from users sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimFG @sre-ci-robot @chyezh