Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: expose more metrics data #39466

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jan 20, 2025

issue: #36621 #39417
pr: #39456

  1. Adjust the server-side cache size.
  2. Add source information for configurations.
  3. Add node ID for compaction and indexing tasks.
  4. Resolve localhost access issues to fix health check failures for etcd.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 20, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (aee9368) to head (a50640d).
Report is 3 commits behind head on 2.5.

Files with missing lines Patch % Lines
pkg/config/manager.go 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39466      +/-   ##
==========================================
- Coverage   82.77%   80.96%   -1.81%     
==========================================
  Files        1104     1404     +300     
  Lines      171249   198070   +26821     
==========================================
+ Hits       141753   160377   +18624     
- Misses      23852    32048    +8196     
- Partials     5644     5645       +1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.46% <ø> (∅)
Go 82.93% <92.85%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/compaction_task_meta.go 75.63% <100.00%> (ø)
internal/datacoord/import_meta.go 94.38% <100.00%> (ø)
internal/datacoord/index_meta.go 96.76% <100.00%> (+0.36%) ⬆️
internal/datacoord/task_scheduler.go 95.79% <100.00%> (ø)
internal/flushcommon/syncmgr/sync_manager.go 90.78% <100.00%> (ø)
internal/proxy/impl.go 83.85% <100.00%> (ø)
internal/querycoordv2/task/scheduler.go 87.37% <ø> (-0.64%) ⬇️
pkg/util/metricsinfo/metrics_info.go 100.00% <ø> (ø)
pkg/util/paramtable/base_table.go 82.50% <100.00%> (+0.11%) ⬆️
pkg/util/paramtable/component_param.go 98.35% <100.00%> (-0.05%) ⬇️
... and 2 more

... and 333 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 20, 2025
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 5, 2025

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 5, 2025

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1. Adjust the server-side cache size.
2. Add source information for configurations.
3. Add node ID for compaction and indexing tasks.
4. Resolve localhost access issues to fix health check failures.

Signed-off-by: jaime <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Feb 7, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ddc5b29 into milvus-io:2.5 Feb 7, 2025
20 checks passed
@jaime0815 jaime0815 deleted the webui-enhance-25 branch February 7, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants