Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: segment stats may be inconsistent after wal closing #39593

Merged
merged 1 commit into from
Feb 5, 2025

fix: segment stats may be inconsistent after wal closing

6553911
Select commit
Loading
Failed to load commit list.
Merged

fix: segment stats may be inconsistent after wal closing #39593

fix: segment stats may be inconsistent after wal closing
6553911
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Feb 5, 2025 in 0s

79.12% of diff hit (target 80.00%)

View this Pull Request on Codecov

79.12% of diff hit (target 80.00%)

Annotations

Check warning on line 229 in internal/streamingcoord/server/balancer/balancer_impl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/balancer/balancer_impl.go#L229

Added line #L229 was not covered by tests

Check warning on line 134 in internal/streamingnode/server/wal/interceptors/segment/inspector/impls.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingnode/server/wal/interceptors/segment/inspector/impls.go#L132-L134

Added lines #L132 - L134 were not covered by tests

Check warning on line 136 in internal/streamingnode/server/wal/interceptors/segment/inspector/impls.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingnode/server/wal/interceptors/segment/inspector/impls.go#L136

Added line #L136 was not covered by tests

Check warning on line 285 in internal/streamingnode/server/wal/interceptors/segment/manager/pchannel_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingnode/server/wal/interceptors/segment/manager/pchannel_manager.go#L279-L285

Added lines #L279 - L285 were not covered by tests

Check warning on line 222 in internal/streamingnode/server/wal/interceptors/segment/stats/stats_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingnode/server/wal/interceptors/segment/stats/stats_manager.go#L222

Added line #L222 was not covered by tests

Check warning on line 189 in internal/streamingnode/server/walmanager/manager_impl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingnode/server/walmanager/manager_impl.go#L188-L189

Added lines #L188 - L189 were not covered by tests

Check warning on line 82 in internal/streamingnode/server/walmanager/wal_lifetime.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingnode/server/walmanager/wal_lifetime.go#L81-L82

Added lines #L81 - L82 were not covered by tests