Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: unindexed collection can be compacted #39650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaofan-luan
Copy link
Collaborator

fix #39633
For unindexed collection, we don't need to wait for index build done before compaction

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Feb 5, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Feb 5, 2025
Copy link
Contributor

mergify bot commented Feb 5, 2025

@xiaofan-luan

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@xiaofan-luan xiaofan-luan changed the title improve: unindexed collection can be compacted enhance: unindexed collection can be compacted Feb 5, 2025
@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Feb 5, 2025
Copy link
Contributor

mergify bot commented Feb 5, 2025

@xiaofan-luan go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (b3791a6) to head (76d8a78).
Report is 8 commits behind head on master.

❌ Your project check has failed because the head coverage (69.39%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (b3791a6) and HEAD (76d8a78). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b3791a6) HEAD (76d8a78)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39650       +/-   ##
===========================================
- Coverage   80.14%   69.39%   -10.75%     
===========================================
  Files        1465      302     -1163     
  Lines      203091    27070   -176021     
===========================================
- Hits       162762    18785   -143977     
+ Misses      34526     8285    -26241     
+ Partials     5803        0     -5803     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.39% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)

see 1165 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Normal compaction doesnt start after import
2 participants