firefox support #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@ShadowVariable I'm having trouble getting the firefox extension packaged and running. Were you able to have success? Do you have time to hop on some messenger and help me figure it out? From what I can tell, we can use the same script and manifest for both chrome and firefox, but I'm having some compatibility issues with my firefox browser. |
|
@ShadowVariable I just realized I made the same PR as you, but mine should work. I believe the issue with yours is that the instances of "chrome" need to be changed to "browser" in the script.js file for firefox |
|
@ryan-mccaffrey I was reading through the Firefox documentation and it said that "chrome" is automatically changed to "browser" when loaded in firefox which is why I didn't change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for firefox.