Merge pull request #314 from mimiro-io/fix/statistics

Fix: avoid possible panic when ctx cancel is unavail

internal/service/scheduler/schedulable.go

@@ -76,6 +76,11 @@ func newSchedulableTask(taskId string, immediateRun bool, logger *zap.SugaredLog
 
 func (s *schedulableTask) Run() {
 	s.lock.Lock()
+	if s.state == TaskStateRunning {
+		s.logger.Infof("Task %s is already running", s.ID())
+		s.lock.Unlock()
+		return
+	}
 	s.state = TaskStateRunning
 	s.lock.Unlock()
 

internal/service/scheduler/statistics_update.go

@@ -54,7 +54,9 @@ func NewStatisticsUpdater(logger *zap.SugaredLogger, store store.BadgerStore) sc
 		ctx, cancel := context.WithCancel(context.Background())
 		stats.cancel = cancel
 		defer func() {
-			stats.cancel()
+			if stats.cancel != nil {
+				stats.cancel()
+			}
 			stats.cancel = nil
 		}()
 		stats.Logger.Infof("gathering counts for all datasets")