Feedback #1
Feedback #1
Conversation
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
README.md
Outdated
|
|
||
| ## Biblioteki | ||
| - Bevy | ||
| - może coś do serializacji danych? (czy mógłby Pan coś polecić?) | ||
| - Bevy/ggez/ może mógłby Pan pomóc dobrać odpowiednią libkę |
There was a problem hiding this comment.
Kodu wydaje się, że jest dużo, ale niestety bardzo duża jego część to powtórzenia i bevy'owy boilerplate. Nazewnictwo bywa niespójne. Kod pod względem technicznym nie jest jakiś zaawansowany. Oceniam na 4/5.
Do zrobienia w drugiej części oprócz tego co sami zaplamowaliście sugeruję wprowadzić determinizm (tzn. użyć RNG który da się seedować), tak żeby dało się np. zagrać dwa razy na tej samej mapie. Testów jednostkowych trochę nie ma w tym momencie do czego pisać, ale może do rzeczy z drugiej części będzie się dało.
Cargo.toml
Outdated
| [dependencies] | ||
| bevy = "0.7" | ||
| bevy_rapier2d = "0.13.2" | ||
| rand = "*" |
src/game/boosters.rs
Outdated
| y: f32, | ||
| ) { | ||
| commands | ||
| .spawn_bundle(SpriteBundle { |
There was a problem hiding this comment.
Potwarza się ten kod, można wyciągnąć do funkcji (i w bevy chyba jaklś da się te bundle robić z parametrami?)
src/game/boosters.rs
Outdated
| coffees: Query<Entity, With<Coffee>>, | ||
| mut collision_events: EventReader<CollisionEvent>, | ||
| ) { | ||
| for collision_event in collision_events.iter() { |
src/game/boosters.rs
Outdated
|
|
||
| pub fn insert_rust_at( | ||
| commands: &mut Commands, | ||
| player_textures: &Res<GameTextures>, |
src/game/boosters.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub fn add_boosters(commands: &mut Commands, world: &[usize], player_texture: Res<GameTextures>) { |
There was a problem hiding this comment.
Tutaj też: nie wiem skąd się to player wzięło
| enemies: Query<Entity, With<Enemy>>, | ||
| mut collision_event: EventReader<CollisionEvent>, | ||
| ) { | ||
| for collision_event in collision_event.iter() { |
src/game/map.rs
Outdated
| 0.0, | ||
| )) | ||
| .insert(RigidBody::Fixed) | ||
| .insert(Collider::cuboid(half_width, 0.5)); |
There was a problem hiding this comment.
Nie znam się jakoś dobrzr na grach, ale zgaduję, że robienie osobnego collidera na tile może być niewydajne
src/game/moster_ai.rs
Outdated
| app.add_event::<MonsterWalkedIntoWallEvent>() | ||
| .add_system_set( | ||
| SystemSet::on_update(AppState::InGame) | ||
| .with_system(monster_walking_system) |
src/game/moster_ai.rs
Outdated
| mut collision_events: EventReader<CollisionEvent>, | ||
| mut send_monster_walked_into_wall: EventWriter<MonsterWalkedIntoWallEvent>, | ||
| ) { | ||
| for collision_event in collision_events.iter() { |
src/game/player.rs
Outdated
| mut query: Query<(Entity, &mut Jumper)>, | ||
| mut contact_events: EventReader<CollisionEvent>, | ||
| ) { | ||
| for contact_event in contact_events.iter() { |
Add util for spawning bundles
# Conflicts: # src/game/audio.rs # src/game/bullets.rs # src/game/camera.rs # src/game/components.rs # src/game/map.rs # src/game/mod.rs # src/game/monster.rs # src/game/moster_ai.rs # src/game/player.rs # src/game/powerups.rs # src/game/utils.rs # src/main.rs # src/menu/mod.rs # src/menu/structs.rs # src/menu/systems.rs # src/menu/utils.rs
…undyra into patryk
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @PBundyra @KatKlo