Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display download bar in front of modal dialogs #1648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sestowner
Copy link
Member

@Sestowner Sestowner commented Jun 12, 2021

Before:
image

After:
image

@PalmerAL
Copy link
Collaborator

Which overlay are you referring to? The searchbar and dialog overlays have a z-index of either 1 or 5, so the download bar should be on top of them already: https://github.com/minbrowser/min/blob/7749a35ea71a5f373c05e1d587b620a7a5f7c1fc/css/modal.css

In the other PR, I was thinking that if you changed the download bar z-index, the overlay's z-index might need to change as well, but since the download bar is unchanged, everything should still just work.

@Sestowner
Copy link
Member Author

Oops , I meant "Display download bar in front of modal dialogs".

@Sestowner Sestowner changed the title Display download bar in front of modal overlays Display download bar in front of modal dialogs Jun 14, 2021
@PalmerAL
Copy link
Collaborator

Oh, that's a good point. It looks like we should just limit the height of the dialog? Something like .modal { max-height: 85vh } might solve this better.

@lubiedo lubiedo added the bug label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants