improved Hungarian localization #2015
Conversation
There was a problem hiding this comment.
Thanks! I left a few comments.
The names of the strings in the translation file are just identifiers that are used in the code - they don't always match the actual text. The actual original text of the strings is listed in the English file: https://github.com/minbrowser/min/blob/master/localization/languages/en-US.json
| @@ -6,28 +6,28 @@ | |||
| these are the items displayed in the menu when you right-click on a page | |||
| */ | |||
| "addToDictionary": null, //missing translation | |||
| "pictureInPicture": null, //missing translation | |||
| "pictureInPicture": "Kép a képben", //missing translation | |||
There was a problem hiding this comment.
Can you remove the //missing translation comments where you've added translations?
| "clearHistoryConfirmation": null, //missing translation | ||
| "enableBlocking": "Blokkolás engedélyezése", //missing translation | ||
| "disableBlocking": "Blokkolás letiltása", //missing translation | ||
| "clearHistoryConfirmation": "Böngészési előzmények törlése", //missing translation |
There was a problem hiding this comment.
The original English version is a question - should this have a question mark?
"clearHistoryConfirmation": "Clear all history and browsing data?",
| @@ -69,10 +69,10 @@ | |||
| "newTask": "Új feladat", //"new" is a verb - it is used for a button at the bottom of the task overlay | |||
| "defaultTaskName": "Feladat %n", //this is the name used for newly-created tasks; %n is replaced with a number ("task 1", "task 2", etc) | |||
| "taskDeleteWarning": { | |||
| "unsafeHTML": null //missing translation | |||
| "unsafeHTML": "Nem biztonságos HTML fájl" //missing translation | |||
There was a problem hiding this comment.
This should be translated based on the English version:
"taskDeleteWarning": {
"unsafeHTML": "Task deleted. <a>Undo?</a>"
},
(unsafeHTML is just a marker that this translation string has HTML inside it; it isn't displayed to the user)
| }, | ||
| "tasksSearchTabs": null, //missing translation | ||
| "returnToTask": null, //missing translation | ||
| "returnToTask": "Vissza a feladathoz", //missing translation |
There was a problem hiding this comment.
Can you confirm this is correct? I would expect it to specify "previous task"
English is:
"returnToTask": "Return to your previous task",
There was a problem hiding this comment.
It is correct, I just missed the "previous" (elöző) word, so I'll fix it along with the others.
And thanks for the comments, It helps a lot.
| "timeRangeToday": "Idő intervalum, ma", //missing translation | ||
| "timeRangeYesterday": "Idő intervalum, tegnap", //missing translation |
There was a problem hiding this comment.
I think these should just be "ma" / "tegnap"?
(If so, the existing translations are wrong also - would you mind fixing those?)
Reviewed, and change some for better understanding, and added new translates.