Do not change the tab activity colour (fade) when quickly skipping past tabs. #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are switching between tabs and you only stay in the tab for <.5s the activity (fade) colour will remain whatever it was previously.
|
@PalmerAL Any thoughts on this? |
|
Sorry for the delay. I like the idea! Regarding the implementation, it doesn't make much sense to me for lastActivity to go backwards. What about implementing this in the tabs model code? https://github.com/minbrowser/min/blob/master/js/tabState/tab.js#L140 Also, there's a small bug - if you opened the browser with an old set of tabs previously, they would be faded out immediately as a side effect of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are switching between tabs and you only stay in the tab for <.5s the activity (fade) colour will remain whatever it was previously.
Before:
After:
