Fix E2E tests (twentyhq#9919)

Fortunately we're not using NODE_ENV=production for our deployment, but we need to think of a better long-term fix. Not easy because Lingui strips out messages in production environment
mind-developer · Jan 30, 2025 · d30f267 · d30f267
1 parent 2be65cd
commit d30f267
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/ci-e2e.yaml b/.github/workflows/ci-e2e.yaml
@@ -81,7 +81,7 @@ jobs:
       run: NODE_ENV=production NODE_OPTIONS="--max-old-space-size=10240" npx nx build twenty-front
 
     - name: Build server
-      run: NODE_ENV=production npx nx build twenty-server
+      run: npx nx build twenty-server
 
     - name: Create and setup database
       run: |

diff --git a/...ages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts b/...ages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts
@@ -548,8 +548,13 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
       return objectMetadata[labelKey];
     }
 
-    i18n.activate(locale);
+    const messageId = generateMessageId(objectMetadata[labelKey] ?? '');
+    const translatedMessage = i18n._(messageId);
 
-    return i18n._(generateMessageId(objectMetadata[labelKey]));
+    if (translatedMessage === messageId) {
+      return objectMetadata[labelKey] ?? '';
+    }
+
+    return translatedMessage;
   }
 }