ADA-SVR (4/4) Test for models #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the error because it's not possible to access it due to the operation of np.dot(X, X.T) on line 39. The only line using this function.
variable unnecessary and without meaning in this context
Add comment about the condition of X from the removal lines
fix typo errors Co-authored-by: bthirion <[email protected]>
lionelkusch
requested review from
bthirion,
Remi-Gau and
jpaillard
and removed request for
jpaillard
This was referenced Dec 26, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a modification of other PR (#74, #73, #99, #100)
This pull request is about the tests for the ada_svr. I added a functional test to complete the unit of test of the functions.