-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for normalization issues #214
Conversation
…. Add Cufinufft Pipe function authored by Chaithya G.R.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we have some tests as well ?
I would strongly recommend adding the changes for cufinufft in #195 as it is tested there. Also, that will allow this PR to be merged smoothly without waiting for finufft/cufinufft releases. |
Questions for you: can this normalization rule be used for the other density compensations methods (e.g. voronoi) ? |
Answer for you: Yes :). It gives stable results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming it matches same as tfkbnufft and tensorflow-nufft. I will rely on you for it @AsmaTANABEN , I dont think we need those tests here run regularly.
I think we can merge when green and @paquiteau lets make a release? |
I think this can be merged right? |
We could merge it yes. However I think this normalization should be refactored to be generalizable to the other density compensation methods (e.g. voronoi, cell-counting etc.). If this is blocking we can post-pone this refactoring to another PR. |
Adjust normalization of density compensation coefficients and adding Cufinufft Pipe function authored by Chaithya G.R.
Resolves #211