Assessment Files #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geshan
suggested changes
Feb 21, 2019
| /** | ||
| * Opens a new connection to database | ||
| */ | ||
| class Database |
| @@ -0,0 +1,78 @@ | |||
| <?php | |||
| require_once('./db.php'); | |||
| class ImageUploader | |||
There was a problem hiding this comment.
Yes, the filename should match the class name. But the task guideline required this specific filename.
| @@ -0,0 +1,78 @@ | |||
| <?php | |||
| require_once('./db.php'); | |||
| require_once('./db.php'); | ||
| class ImageUploader | ||
| { | ||
| private $src = './media/'; |
| } | ||
| $migratedRows = getRows(); | ||
| ?> | ||
| <html lang="en"> |
There was a problem hiding this comment.
I would suggest separating view and other work.
| { | ||
| $mysqli = $this->db->connect(); | ||
|
|
||
| $result = $mysqli->query("INSERT INTO ".$this->migrate_table." ( sku, name ) |
There was a problem hiding this comment.
Sql injection is possible with this look at parameterized query.
| { | ||
| echo 'Migration Successful'; | ||
| } | ||
| else |
There was a problem hiding this comment.
Else can easily be avoided most if the times use ternary operator.
Thanks for your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.