MBX-0000: Xcode recommendations fix #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix No calls to throwing functions occur within 'try' expression
Class must restate inherited '@unchecked Sendable' conformance
…h '_' or removing it`
Run script build phase 'Increment Build Number Script' will be run during every build because it does not specify any outputs. To address this issue, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase.
Skipping duplicate build file in Compile Sources build phase: /Users/semko/dev/iOS/ios-sdk/Mindbox/InAppMessages/Models/CustomerSegment/SegmentationCheckResponse.swift
…onsider replacing with '_' or removing it`
|
Нужно обратить внимание на подход с отключением |
|
MBX-0000: MindboxTests fix InAppTargetingRequestsTests with deprecated Тут полностью можно убрать использование deprecated переменной в принципе, судя по тестам и реализации основного класса. Надо сделать мне будет фикс и закомменченный вариант выкинуть, если апрувнем это |
Vailence
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Здесь можно посмотреть какие пункты Xcode предлагал исправить конкретно в настройках проекта
Apple Module Verifier
https://developer.apple.com/documentation/xcode/identifying-and-addressing-framework-module-issues
Always Embed Swift Standard Libraries
Протестировал CocoaPods и SPM с обновлениями, всё было хорошо.
Всё разбито строго по коммитам