Merge pull request #13 from mindbox-moscow/fix/booleanValuesInXML

correct boolean values in XML
mindbox-cloud · May 6, 2019 · 7dd8fc6 · 7dd8fc6
2 parents f71bab8 + 7743a21
commit 7dd8fc6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/XMLHelper/MindboxXMLSerializer.php b/src/XMLHelper/MindboxXMLSerializer.php
@@ -47,6 +47,8 @@ private static function getXML(&$xml, array $data)
             if (is_array($value)) {
                 $subNode = $xml->addChild($key);
                 self::getXML($subNode, $value);
+            } elseif (is_bool($value)) {
+                $xml->addChild($key, var_export($value, true));
             } else {
                 $xml->addChild($key, $value);
             }

diff --git a/tests/DTO/DTOTest.php b/tests/DTO/DTOTest.php
@@ -184,13 +184,13 @@ public function asXmlFieldsProvider()
                     'someDtoField'   => $this->getDto(['dto' => 'value']),
                 ],
                 '<?xml version="1.0" encoding="utf-8"?>
-<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>1</someField><someArrayField><field>value</field></someArrayField><someDtoField><dto>value</dto></someDtoField></' . $this->getXmlName() . '>
+<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>true</someField><someArrayField><field>value</field></someArrayField><someDtoField><dto>value</dto></someDtoField></' . $this->getXmlName() . '>
 ',
             ],
             [
                 ['name' => 'Andrew', 'age' => 33, 'someField' => true, 33 => '345'],
                 '<?xml version="1.0" encoding="utf-8"?>
-<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>1</someField><value>345</value></' . $this->getXmlName() . '>
+<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>true</someField><value>345</value></' . $this->getXmlName() . '>
 ',
             ],
             [