Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove score from trusty evaluator #5390

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

eleftherias
Copy link
Contributor

Summary

This is a temporary fix, since this code will eventually be removed from Minder and rewritten as a ruletype.

The Trusty ruletype was getting very noisy because every package had a score of 0. This fixes the PR comment so it only comments when the package is malicious, deprecated, has activity beneath the threshold or provenance beneath the threshold.
It also renames Trusty to Stacklok Insight in the PR comment.

Fixes #4944

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner January 31, 2025 17:07
@eleftherias eleftherias merged commit f07f170 into mindersec:main Jan 31, 2025
26 checks passed
@eleftherias eleftherias deleted the trusty-rule-no-score branch January 31, 2025 19:46
@eleftherias eleftherias mentioned this pull request Feb 3, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trusty score is 0 when Minder comments on PR
3 participants