Pinned PyTorch Version to Support Windows Installations #1233
+75
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusvyat
approved these changes
Nov 27, 2024
@dusvyat I think the only place where this becomes incompatible is here, i.e., if one chooses to use both the Lightwood and HuggingFace integration, which I feel is quite unlikely. Since we provide separate Docker images for both of these integrations, I don't believe this is an issue. |
|
We have different images for those, but I think HF should work with this version too. We may test it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the version of PyTorch to ensure a versions that is supported by Windows is installed.
Please refer to the comments in the issue linked below for further information about the evaluation conducted prior.
Fixes https://linear.app/mindsdb/issue/BE-507/for-investigation-local-windows-support
The import seems to work without an issue (on Windows):
