PixArt-Sigma basic training/inference script #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhtmike
requested review from
CaitinZhao,
SamitHuang and
zhanghuiyao
as code owners
…ate ckpt save interval
zhtmike
changed the title
SamitHuang
reviewed
Sep 5, 2024
|
|
||
| ## Benchmark | ||
|
|
||
| ### Training |
There was a problem hiding this comment.
pls add qualititative or visual evaluation results
CaitinZhao
approved these changes
Sep 5, 2024
SamitHuang
reviewed
Sep 5, 2024
| ] | ||
| ) | ||
|
|
||
| @ms.jit |
There was a problem hiding this comment.
almost all mindspore optimizers implementation are using jit to accelerate training. Here it is following the same practice.
|
|
||
| return y | ||
|
|
||
| @ms.jit |
There was a problem hiding this comment.
it is faster in batch inference in pynative mode, no effect in graph mode
SamitHuang
approved these changes
Sep 13, 2024
zhanghuiyao
approved these changes
Sep 13, 2024
geniuspatrick
approved these changes
Sep 13, 2024
vigo999
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx