Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MovieGen - TAE #778

Merged
merged 22 commits into from
Jan 2, 2025
Merged

Add MovieGen - TAE #778

merged 22 commits into from
Jan 2, 2025

Conversation

SamitHuang
Copy link
Collaborator

@SamitHuang SamitHuang commented Dec 10, 2024

What does this PR do?

Fixes # (issue)

Adds # (feature)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

hadipash added a commit to hadipash/mindone that referenced this pull request Dec 11, 2024
@SamitHuang SamitHuang requested a review from vigo999 December 12, 2024 10:13
@@ -0,0 +1,50 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to mindone common dir?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm as it is not related to this PR

@@ -0,0 +1,151 @@
# Movie Gen Video based on MindSpore

This project is built on the [Movie Gen](https://arxiv.org/abs/2410.13720) paper by Meta for video generation, personalization, and editing. We aim to explore an efficient implementation based on MindSpore and Ascend NPUs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set a link to doc/report?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

def construct(self, x):
if self.with_conv:
pad = ((0, 0), (0, 0), (0, 1), (0, 1))
x = nn.Pad(paddings=pad)(x)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use mint.nn.function.pad?

# export ASCEND_RT_VISIBLE_DEVICES=7
# improve data loading performance for distributed training: 1
export MS_ENABLE_NUMA=0
# plot memory usage, feature/model: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- # plot memory usage, feature/model: 1
-export MS_MEMORY_STATISTIC=0
-export MS_DATASET_SINK_QUEUE=8
+# plot memory usage and compile info
+# export MS_DEV_RUNTIME_CONF="memory_statistics:True,compile_statistics:True"

@SamitHuang SamitHuang added this pull request to the merge queue Jan 2, 2025
Merged via the queue into mindspore-lab:master with commit e129159 Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants