Add Movie Gen #783
Open
Add Movie Gen #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Movie gen
enable jit_level `O2` support
- preserve image / video orientation in transformations
SamitHuang
reviewed
Dec 19, 2024
# Conflicts: # mindone/utils/env.py
# Conflicts: # examples/moviegen/inference.py
zhanghuiyao
approved these changes
Jan 3, 2025
# Conflicts: # examples/moviegen/README.md # examples/moviegen/configs/tae/train/mixed_256x256x16.yaml # examples/moviegen/configs/tae/train/mixed_256x256x32.yaml # examples/moviegen/docs/report.md # examples/moviegen/mg/models/tae/tae.py # examples/moviegen/scripts/args_train_tae.py # examples/moviegen/scripts/run/run_train_tae.sh # examples/moviegen/scripts/train_tae.py
# Conflicts: # examples/moviegen/docs/report.md
SamitHuang
reviewed
Jan 4, 2025
There was a problem hiding this comment.
there are 7 scripts in the top folder (train.py, train_tae.py, inferecne_text_enc.py...), which is unlike previous case using a unified train.py/infer.py as the only entrance. So I would suggest put them in scripts/ folder to keep the top code structure clean
Comment on lines
+8
to
+10
| Meta researchers found that scaling the training data, compute, and model parameters of a simple | ||
| Transformer-based ([LLaMa3](https://arxiv.org/abs/2407.21783)) model trained with | ||
| [Flow Matching](https://arxiv.org/abs/2210.02747) yields high quality generative models for video or audio. |
There was a problem hiding this comment.
i think it's better to delete this paragraph to keep the README concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx