Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Enhancement for #34 - Divide Armor Wear by # Pieces #38

Merged
merged 1 commit into from
Dec 26, 2020

Conversation

sirrobzeroone
Copy link

See Details contained in #34

Note1: I split out the fix for Issue 13 and it has been applied
Note2: I will also do a seperate pull request for Issue 30

From what I understand smaller specific pull requests allow for reversion of specific additions and features much more easily. Please do correct me if I have the wrong end of the stick on this.

See Details contained in minetest-mods#34

Note1: I split out the fix for Issue 13 and it had been applied
Note2: I will also do a seperate pull request for Issue 30

From what I udnerstand smaller specific pull requests allow for reversion of specific additions and features much more easily. Please do correct me if I have the wrong end of the stick on this.
@BuckarooBanzay
Copy link
Member

From what I understand smaller specific pull requests allow for reversion of specific additions and features much more easily. Please do correct me if I have the wrong end of the stick on this.

Pretty much, yes 👍
Bigger PR's are ok too but may need more time to test/review...

@BuckarooBanzay BuckarooBanzay merged commit 3ddcbae into minetest-mods:master Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants