Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on compatibility layer
sounds
. It overridesdefault.node_sound_*
, so further modification shouldn’t be necessary, though it’s possible.The code assumed that the existence of
stairs
impliesdefault
is also there, but Stairs Redo, Stairs Redux and “moreblocks and stairsplus ” supply a replacement. moreblocks and stairsplus does not depend on default, which led to crash.In MineClone2 this results in the bottle having destruction sound.
I’m testing in MineClone2 with sounds and “moreblocks and stairsplus” installed. Sounds for breaking the bottle as well as for walking on stairs and moreblocks works.
The sound for normal lava block doesn’t work, which is one reason why this is WIP.
It could further be checked if
adaptation_lib
can replace or extend the current compatibility.