Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve sound compatibility #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

basxto
Copy link

@basxto basxto commented Aug 21, 2023

Depends on compatibility layer sounds. It overrides default.node_sound_*, so further modification shouldn’t be necessary, though it’s possible.

The code assumed that the existence of stairs implies default is also there, but Stairs Redo, Stairs Redux and “moreblocks and stairsplus ” supply a replacement. moreblocks and stairsplus does not depend on default, which led to crash.

In MineClone2 this results in the bottle having destruction sound.
I’m testing in MineClone2 with sounds and “moreblocks and stairsplus” installed. Sounds for breaking the bottle as well as for walking on stairs and moreblocks works.

The sound for normal lava block doesn’t work, which is one reason why this is WIP.

It could further be checked if adaptation_lib can replace or extend the current compatibility.

@LoneWolfHT
Copy link
Collaborator

Thanks for the PR!

The sound for normal lava block doesn’t work, which is one reason why this is WIP.

You can ping me when it's done

It could further be checked if adaptation_lib can replace or extend the current compatibility.

I try to balance the crafts in different games based on rarity, which is probably hard to account for with that mod.

@basxto
Copy link
Author

basxto commented Aug 22, 2023

It could be interesting for lava in a bottle, though probably overkill for just one item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants