-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support doors and trapdoors from mods #683
Conversation
Removed hardcoded door names and instead now use the API of the door mod to meseconify all doors and trapdoors that have been registered after the mods are finished loading.
I tested it with the sakura door from ethereal ng. At first I was angry that ethereal ng door didn't work with mesecons and thought they were lazy goodfornothings but then I looked at the code and it uses the door mod and mesecon patches those doors, so it should work, but only for hardcoded values rather than using the api. So I made this fix to automatically support all doors ever made and going to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
Thanks for adding this here! This makes mesecons integration in some mods obsolete, notably
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Tested ingame, works as expected.
Removed hardcoded door names and instead now use the API of the door mod to meseconify all doors and trapdoors that have been registered after the mods are finished loading.