Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support doors and trapdoors from mods #683

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

mruncreative
Copy link
Contributor

Removed hardcoded door names and instead now use the API of the door mod to meseconify all doors and trapdoors that have been registered after the mods are finished loading.

Removed hardcoded door names and instead now use the API of the door mod to meseconify all doors and trapdoors that have been registered after the mods are finished loading.
mesecons_doors/init.lua Outdated Show resolved Hide resolved
mesecons_doors/init.lua Outdated Show resolved Hide resolved
mesecons_doors/init.lua Outdated Show resolved Hide resolved
@mruncreative
Copy link
Contributor Author

I tested it with the sakura door from ethereal ng. At first I was angry that ethereal ng door didn't work with mesecons and thought they were lazy goodfornothings but then I looked at the code and it uses the door mod and mesecon patches those doors, so it should work, but only for hardcoded values rather than using the api. So I made this fix to automatically support all doors ever made and going to be made.

Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@Niklp09
Copy link
Member

Niklp09 commented Oct 4, 2024

Thanks for adding this here!

This makes mesecons integration in some mods obsolete, notably

  • homedecor (mt-mods)
  • mydoors (minetest-mods)
  • xdecor_libre (Wuzzy)

Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested ingame, works as expected.

@Niklp09 Niklp09 merged commit b46c589 into minetest-mods:master Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants