Feature of homedecor

[bell07]

Homedecor is moved to https://github.com/mt-mods/homedecor_modpack and got some updates

Last commits does remove stairs

Some things are moved to home_workshop_modpack

Both changes may breaks compatibility. The home_workshop_modpack needs to be considered if any mods needs to be added to whynot for compatibility :-(.

[bell07]

home_vending_machines and home_workshop_misc contains the vending machines.
Unsure if any other items are removed.

Unresolved: See no way to get the stairs back :-( Remove them and force users to remove the "unknown node" 's?

[bell07]

Moved homedecor forward to 63ad77e2429faefb1c4ac9f900fe759015791134. This commit contains the "Enable sleep" patch, but before the stairs support is removed. Added home_vending_machines and home_workshop_misc to cover other removed items.

This issue is still not solved till a new fork appears with support to the stairs mod.

[Lazerbeak12345]

We need to make an issue for homedecor. I'll do that right now. (done)

[wsor4035]

see mt-mods/homedecor_modpack#17 (comment) that stairs are still supported. the home_workshop_modpack split out from homedecor was a decision made by vennessae every before the repos where moved to mt-mods

[wsor4035]

if really must feel the need to keep using the terrible stairs api and want to fix all the warnings and issues yourself, i would suggest making a fake moreblock mod that maps there api back to the mtg stairs api

[bell07]

I am undecided if we should
-Fully remove the homedecor stuff and do a breakting compatibility release. The homedecor is one of the mods with high resolution textures and 3D models ..

• Just add the stairs in whynot_compat mod
• Utilize my customnode mod that supports stairs API

At the first we need to check which stairs in detail are missed ..

[wsor4035]

as you can see in https://github.com/mt-mods/homedecor_modpack/pull/16/files the only stairs that where "removed" is from building blocks mod. more over moreblocks is the defacto standard in the rest of homedecor

[wsor4035]

for a simple patch for this project if you want to bring the old stair nodes back, is depend on building blocks, and then loop through minetest.registered_nodes and do a if check for mod_origin = building blocks and then register a stair

[bell07]

Just for reference, maybe we need to reconsider the #25
For quick solution we should just add the missed stairs into whynot-compat mod, after #56

[wsor4035]

not tested, but should work?

for name, def in pairs(minetest.registered_nodes) do
  if def.mod_origin == "building_blocks" then
    stairs.register_stair_and_slab(
      name:split(":")[2],
      name,
      def.groups,
      def.tiles,
      def.description .. " stair",
      def.description .. " slab",
      def.sounds
    )
  end
end

[wsor4035]

^above is to restore functionality as it was before, your still on the hook for fixing all the warnings and issues

[Lazerbeak12345]

See re-review of the moreblocks mod in #25

[bell07]

If we have a chance to get the issue solved by upstream (eather if we add moreblocks or stairsplus into Whynot or homedecor provide an legacy compatibility), we should wait. The homedecor_modpack is frozen in check-updates.sh till the issue is solved or any other compatibility issues appear. The whynot-compat is for issues not solvable (or rejected) by upstream ..

[bell07]

[EDIT] - The issue was on my site :-(

[bell07]

Updated homedecor with #63. Please check if the changes can be merged.

Or solution 2, we break compatibility,remove homedecor, most of whynot_compat parts, and maybe other mods from the game.
Then we are able to consider each mod separately for whynot rules.
Homedecor is in my game since first days of the game, before the whynot rules was written

[Lazerbeak12345]

That's a good point. Does homedecor even meet the rules? Has it ever met the rules?

[bell07]

That's a good point. Does homedecor even meet the rules? Has it ever met the rules?

No, and No. Homedecor was a big blob previously and was one of the first mods in my mods collection.
As I started whynot, my childs liked the furnitures from homedecor, so I keept them in game as exception.

In the meantime the homedecor is splitted down in modpack. Some mods, like 3d_extras I removed shortly, but consider each mod separately for whynot rules is still outstanding

[bell07]

The initial cause for this issue is solved now. Therefore I close this issue.
Additional discussions about Homedecor's check against whynot rules and maybe compatibility-breaking removal is a new issue worth.