[Mod Request]: realms

[Lazerbeak12345]

Request

This is the URL for the mod I would like to be added:

https://forum.minetest.net/viewtopic.php?f=9&t=22670

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this mod take over the game?
   • Mapgen
2. When could this mod be a strain on the server when no players are using the mod?
   • Unknown. Likely never.
3. When does this mod destroy player's work?
   • Unknown. Likely never.
4. Have you looked at the code? If so, what stood out as things that might need fixing?
   • No. THIS NEEDS DONE.
5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
   • Unknown.
6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
   • Most likely. Provides no items.
7. When does this mod feel like cheating?
   • Likely never.
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • Yes. https://github.com/Kilarin/realms
9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
   • UNTESTED. NEEDS DONE
10. Legal
    • Code MIT
    • Images CC0
    • All properly documented in readme and in licence file.
    • No issues :)

Other comments

Sorta suggested by @dacmot in #83 (comment)

I'm really just putting this here so we don't forget about it.

[Lazerbeak12345]

To playtest this, I'm going to do two things:

1. Test if the game Fractured (which includes this mod) still works on the version of minetest I have on my computer.
2. Add realms as a mod in my mods file, and make a suitable config file.

That gets into the config file thing.

For this mod to work in whynot, we must be sure to properly configure it. It looks like it might not work (or would be pointless) without configuration.

Alternatively, we could simply let our users do the config on their own worlds. I would be ok with this, but that defeats the whole reason this mod came up (technical issues beside). If we were to add this mod, it'd be to allow for mods that add mapgen changes to work without breaking things. (My opinion on such breakage and how much it actually matters seems to generally differ from bell07 and dacmot)

[Lazerbeak12345]

Here's my results for the Fractured playtest:

I kept getting an error message from a dungeon_loot mod. Things started working after I disabled that mod (which wasn't relevant to whynot in this capacity anyway).

The realms seem to work - though there's a lot of log messages going on. Like a lot of logging. I'm hoping that logging is not from the realms mod.

Also, generation is much slower. So slow that on my first play test I glitched through the ground. It was fine on my next few tests, but still not very fast.

[dacmot]

I'm a bit disappointed realms (and Fractured) were abandoned before being complete. I really like the idea. I've mentioned before some ideas for underground (caverealms, underch, nether), and above ground (see about using some of the many biomes in ethereal at different altitudes).

As for the performances, if there's a lot of log, that could be causing slowdown. I/O is notorious for being one of the worse performance offender. If you can find the source of those logs and disable them, I wouldn't be surprised if your performance improved significantly thereafter.

[Lazerbeak12345]

Updated legal.

[Lazerbeak12345]

@dacmot the code hasn't been touched since 2019. Seems pretty abandoned to me.

What do you think? Should we close this issue?

Further, I can't find luautils anywhere. It's not on content db, nor can I find it in this modsearch tool

[dacmot]

Yeah. I don't think this will be completed anytime soon. In any case, we can always re-consider at a later date.

[Lazerbeak12345]

Since luathreads on mapgen is now possible (luanti-org/luanti#13092) I suspect it would be better to rewrite this mod anyway.