initial whynot_awards

[bell07]

Initial whynot_awards mod

• Hide all default awards to secret
• Add new award for sleeping in bed once

Please pull additional awards directly to whynot_awards branch. I think we need some "base" before we can merge it into main branch

[Lazerbeak12345]

Marked as draft. We need some design-level questions answered first before we keep coding. Ofc if theres something we are in agreement on, like before, just push it.

[dacmot]

I've started working on a awards tree diagram with Dia. Let me know what you think.

I'm trying really hard not to put an award for everything :) Seriously though, I feel like it gives a good progression and pointers to get started. I just thought, I forgot to put armor. Some of those achievements will require modifications to the awards mod...

[Lazerbeak12345]

Great graph! I like it, though it's sideways.

[dacmot]

I tried to print it landscape so it would fit better on a single page... the PDF is more a convenience anyway since the source is the .dia file.

I could remake it top down... might make more sense anyway as we add more awards than can fit on a single page.

[Lazerbeak12345]

I'm pretty sure you could just rotate the PDF for now. That's a feature, I'm pretty sure.

[Lazerbeak12345]

This looks good so far.

[dacmot]

This looks good so far.

I haven't been working in this branch directly (yet). It dates back to over a year ago.

I've been toying with different triggers (and gradually adding awards) in https://github.com/dacmot/minetest-game-whynot/tree/new_awards

[Lazerbeak12345]

It's actually mostly the images I'm worried about.

[dacmot]

I also want to add translations (locale) for the awards before merging. I'll do the french one because that's what I know :)

edit: done.

[dacmot]

Need to add images for some of the awards.

edit: done.

[dacmot]

Need to figure out what's wrong with "Gather and eat wild foodstuff". Doesn't always register something was eaten.

edit: It seems that eating a standalone item (stack=1) won't register eating the item because when we get to the register_on_item_eat callback, the stack is empty and the item name is nil or empty. If the itemstack has two or more items it works fine.

edit2: This does not happen in plain MTG+awards mod. Also, https://github.com/minetest/minetest/blob/e12db0c1828e84693d2fca2eaf2292006767d1f4/builtin/game/item.lua#L404 shows that callbacks are called before removing an item from the stack.

edit3: The culprit seems to be hbhunger. It overrides minetest.do_item_eat and runs the callbacks after taking an item from the stack instead of before like the original function.

edit4: #191

edit 5: merged.

[Lazerbeak12345]

Is hbhunger even maintained anymore?

[dacmot]

I think so. Last modified 9 months ago. By Wuzzy who's still otherwise very active in the minetest community.

…

-------- Message d'origine -------- Le 2024-04-08 15 h 08, Lazerbeak12345 a écrit :

Is hbhunger even maintained anymore? — Reply to this email directly, [view it on GitHub](#66 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFQHO6FQG6TL2CBL35IFYVTY4LTMDAVCNFSM5PERCV5KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGM2DONRRGE3A). You are receiving this because you commented.Message ID: ***@***.***>

[dacmot]

I finally got around to adding the last icons for the distance, depth and altitude awards. I'm a terrible graphics artists... so it is what it is. For now. We can maybe ask for help on the forums once it is released.

Speaking of which, I think it's ready for beta testing. @Lazerbeak12345 if you want to give it a shot and let me know what you think, I'd be very grateful.

It's made for the natural progression in survival so not all the awards show up at first. You can use creative to acquire materials quicker, but you still need to follow the order and get the ones displayed in the list.

[Lazerbeak12345]

Haven't playtested it yet, but this looks awesome so far!