feat(menu): propTypes && defaultProps

ming680 · Jul 8, 2024 · 29036b4 · 29036b4
1 parent 7bf4b92
commit 29036b4
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 14 deletions.
diff --git a/src/menu/Menu.tsx b/src/menu/Menu.tsx
@@ -5,7 +5,6 @@ import { getChildrenArray, hasSlot } from '../_util/component';
 import { convertToLightDomNode } from '../_util/lightDom';
 import { StyledProps } from '../common';
 import { DEFAULT_MENU_WIDTH } from './_util/constant';
-import { menuDefaultProps } from './defaultProps';
 import { MenuValue, TdMenuProps } from './type';
 
 export interface MenuProps extends TdMenuProps, StyledProps, OmiDOMAttributes {}
@@ -14,7 +13,17 @@ export interface MenuProps extends TdMenuProps, StyledProps, OmiDOMAttributes {}
 export default class Menu extends Component<MenuProps> {
   static css = [];
 
-  static defaultProps = {};
+  static defaultProps: TdMenuProps = {
+    collapsed: false,
+    width: '232px',
+  };
+
+  static propTypes = {
+    collapsed: Boolean,
+    value: [String, Number],
+    width: [String, Number, Array],
+    onChange: Function,
+  };
 
   active = signal<MenuValue>('');
 
@@ -29,10 +38,7 @@ export default class Menu extends Component<MenuProps> {
   }
 
   render() {
-    const { className, style, width, collapsed, value } = {
-      ...menuDefaultProps,
-      ...this.props,
-    };
+    const { className, style, width, collapsed, value } = this.props;
 
     this.active.value = value;
 

diff --git a/src/menu/MenuItem.tsx b/src/menu/MenuItem.tsx
@@ -16,6 +16,16 @@ export default class MenuItem extends Component<MenuItemProps> {
     }
   `;
 
+  static propTypes = {
+    label: Object,
+    disabled: Boolean,
+    href: String,
+    icon: Object,
+    target: String,
+    value: [String, Number],
+    onClick: Function,
+  };
+
   inject = ['active', 'onChange'];
 
   constructor() {

diff --git a/src/menu/defaultProps.ts b/src/menu/defaultProps.ts