User experience #277
Merged
User experience #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fersoil <Fersoil>
* by default now the intersection of analytes is included in multiplate report * remove T as TRUE indicator * preserve user's setting --------- Co-authored-by: Fersoil <Fersoil>
* by default now the intersection of analytes is included in multiplate report * remove T as TRUE indicator * preserve user's setting * more verbose warnings and errors * added proper sample ordering during initialisation * test fixes - NULL mfi_min * removing the user's option to reorder the plate * add docs on the sample order * added description of sample types detection * update docs * remove the remaining code * update the example script vignette index * update the links to docs * update the docs * added tests for model --------- Co-authored-by: Fersoil <Fersoil>
* Fix relative path in process_dir and process_file * Add relative path test
* Update README.md * Update README.md
* Implement direct MFI output as normalisation type * Add MFI info to docs * Blanks are not adjusted but use in the adjustment
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 89.85% 90.32% +0.47%
==========================================
Files 17 17
Lines 2139 2388 +249
==========================================
+ Hits 1922 2157 +235
- Misses 217 231 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* warning for high hook * better message for error * handle visual side for bad coverage of standard curve warning * refactor and clean code * logic for numbers * adjust test mockup so that it works with warnings
* Implement direct MFI output as normalisation type * Add MFI info to docs * Blanks are not adjusted but use in the adjustment * added dataset * updated docs for process class methods * layout file is no longer required in process_dir * added better docs for process class methods * added draft of multiplate tutorial * Fix invalid utf8 (#273) * Replace readr with stringi allowing for non utf-8 characters * Allow setting separator to tab * enhanced the docs and finished the multiplate tutorial * added better warnings and errors * removed plate with a different separator * added vignette on single plate * rerun docs * update the imports after removing readr from xponent parser * reduced the example line width * vignette fixes * added multiple links to sample type detection overview * multiplate plots in our plots vignette created with new data * added tests for process_dir * added more tests * more tests * restored mistakenly removed files * added even more tests * img and warnings * update the paths --------- Co-authored-by: ZetrextJG <[email protected]> Co-authored-by: Fersoil <Fersoil> Co-authored-by: Jakub Grzywaczewski <[email protected]> Co-authored-by: nizwant <[email protected]>
* refactor of the most obvious problems * smaller refactor
Co-authored-by: Fersoil <Fersoil>
* added an option for generating multiplate report in process_dir * added testing for process dir reports generation * error fix * fixing another typo * another typo --------- Co-authored-by: Fersoil <Fersoil>
nizwant
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.