Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for namespaces (Consul Enterprise) #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vlatkoboshkoski-rldatix
Copy link

@vlatkoboshkoski-rldatix vlatkoboshkoski-rldatix commented Jun 28, 2021

This is implementation of the namespace feature in Consul that is available in the Enterprise version only.
https://www.consul.io/api-docs/txn#namespace

Discussed here: #27

@vlatkoboshkoski-rldatix
Copy link
Author

Do you need any additional info from me? Probably you can not test the enterprise features.

@paulo-ferraz-oliveira
Copy link
Contributor

Hi, @vlatkoboshkoski-allocate.

This pull request has conflicting files, so a rebase is probably in order.

Also, would it be possible for you to add some tests, for future non-regression?

Thanks.

remove namespace instructions
@vlatkoboshkoski-rldatix
Copy link
Author

I am not sure about the tests, you will need Terraform Enterprise account to test it

@vlatkoboshkoski-rldatix
Copy link
Author

Any updates? @paulo-ferraz-oliveira

@paulo-ferraz-oliveira
Copy link
Contributor

Only saw this now, sorry about that.

I'm not saying I should write or do tests 😄

What I mentioned is we'd like you to add some tests (maybe mock something) so there's no future regressions against your changes.

Thanks.

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Add support for namespaces Add support for namespaces (Consul Enterprise) May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants