fix(fever): correct sorting direction when using max_id argument

miniflux · Aug 18, 2024 · f3a5a3e · f3a5a3e
1 parent e98e16e
commit f3a5a3e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/fever/handler.go b/internal/fever/handler.go
@@ -247,7 +247,6 @@ func (h *handler) handleItems(w http.ResponseWriter, r *http.Request) {
 	builder := h.store.NewEntryQueryBuilder(userID)
 	builder.WithoutStatus(model.EntryStatusRemoved)
 	builder.WithLimit(50)
-	builder.WithSorting("id", model.DefaultSortingDirection)
 
 	switch {
 	case request.HasQueryParam(r, "since_id"):
@@ -258,6 +257,7 @@ func (h *handler) handleItems(w http.ResponseWriter, r *http.Request) {
 				slog.Int64("since_id", sinceID),
 			)
 			builder.AfterEntryID(sinceID)
+			builder.WithSorting("id", "ASC")
 		}
 	case request.HasQueryParam(r, "max_id"):
 		maxID := request.QueryInt64Param(r, "max_id", 0)

diff --git a/internal/storage/entry_query_builder.go b/internal/storage/entry_query_builder.go
@@ -402,13 +402,13 @@ func (e *EntryQueryBuilder) GetEntryIDs() ([]int64, error) {
 	query := `
 		SELECT
 			e.id
-		FROM 
+		FROM
 			entries e
 		LEFT JOIN
 			feeds f
 		ON
-			f.id=e.feed_id 
-		WHERE 
+			f.id=e.feed_id
+		WHERE
 			%s %s
 	`