Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feed/Category mapper for integrations #2125

Closed
wants to merge 0 commits into from
Closed

Feed/Category mapper for integrations #2125

wants to merge 0 commits into from

Conversation

jeankhawand
Copy link
Contributor

Do you follow the guidelines?

jeankhawand
jeankhawand commented Oct 11, 2023
View reviewed changes
internal/integration/apprise/apprise.go Outdated
"urls": appriseConfig.Feeds[strconv.Itoa(int(entry.FeedID))],
"body": message,
})
// TODO - add function to fetch category related to this entry
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do get null pointer on this one, need to check on how to mount categories with feed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we limit functionality to feed only?

@jeankhawand
Copy link
Contributor Author

jeankhawand commented Oct 11, 2023 •
edited
Loading

This overriding default browser check for required input field

v2/internal/ui/static/js/app.js

Lines 60 to 69 in 9f62704

element.onsubmit = () => {
let button = element.querySelector("button");
if (button) {
button.innerHTML = button.dataset.labelLoading;
button.disabled = true;
}
};
});
}

I am unable to force users to fill required input field (token fields) before submitting. We might have a case where user will submit empty value for a respective category / feed

jeankhawand
jeankhawand commented Oct 11, 2023
View reviewed changes
internal/ui/static/js/cf_component.js Outdated
keyInput.appendChild(option_group);
}
if (category) {
const category_value = this.categoryValue.filter(obj => obj.title !== "All");
Copy link
Contributor Author

@jeankhawand jeankhawand Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter category All since we have a default entry which will act as catch-all

@jeankhawand
Copy link
Contributor Author

Hi @fguillot you will encounter issue while typing in ValueInput and that's because KeyboardHandler listening on keydown. can we disable this for integrations?
image

@jeankhawand
Copy link
Contributor Author

Hi @fguillot you will encounter issue while typing in ValueInput and that's because KeyboardHandler listening on keydown. can we disable this for integrations? image

Ok I see now, because I am using web component it's not ignoring it. should be fine now

@jeankhawand
Copy link
Contributor Author

Hello @fguillot , can we have a discussion on this one? Thanks

@jeankhawand jeankhawand mentioned this pull request Dec 3, 2023
Open
@jeankhawand jeankhawand force-pushed the feat/add-kv-component branch from d02052b to a15cdb1 Compare March 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflicts detected / rebase required
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeankhawand @fguillot