feat(apprise): add title in notification request body #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fguillot
reviewed
Dec 3, 2024
| "body": message, | ||
| "urls": c.servicesURL, | ||
| "body": message, | ||
| "title": entry.Feed.Title, |
There was a problem hiding this comment.
I don't think entry.Feed.Title is populated in this case. It would be more appropriate to pass feed *model.Feed to this function and use feed.Title (similar to other integrations like Nfty or Telegram).
There was a problem hiding this comment.
I don't think
entry.Feed.Titleis populated in this case. It would be more appropriate to passfeed *model.Feedto this function and usefeed.Title(similar to other integrations like Nfty or Telegram).
Thank you for your review. I have modified it according to the implementation of Ntfy. Please review it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you follow the guidelines?
This pull request includes a small but important change to the
internal/integration/apprise/apprise.gofile. The change involves adding the feed title to the notification request body, which ensures that the notifications sent include the title of the feed entry.internal/integration/apprise/apprise.go: Added thetitlefield to the JSON request body in theSendNotificationfunction to include the feed title in notifications.This title is useful in mobile notifications, or it's "Apprise Notifications".
This is the first PR I submitted to miniflux. Please forgive me if there are any shortcomings.