Simplify hasRequiredAttributes #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function takes around 1.5% of the total CPU time on my instance, and most of it is spent in `mapassign_faststr` to initialize the `map`. This is replaced with a switch-case construct, that should be both significantly faster as well as pretty dull in term of memory consumption.
jvoisin
force-pushed
the
simplify_hasRequiredAttributes
branch
from
99b4f0c to
0cce604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function takes around 1.5% of the total CPU time on my instance, and most of it is spent in
mapassign_faststrto initialize themap. This is replaced with a switch-case construct, that should be both significantly faster as well as pretty dull in term of memory consumption.